Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema creation errors while adding a new connection #3490

Merged
merged 1 commit into from Mar 15, 2024

Conversation

Anish9901
Copy link
Member

Fixes #3420

Technical details

It seems like Brent already had this potential failure in mind while working on implementing Connection RPC endpoints and the error handling was appropriately added. The exception class added however was the base exception for the underlying SQLAlchemy exception that was being generated, as detailed in the issue. This PR aims to improve this behavior by catching the specific SQLAlchemy exception rather than its base. Additionally, we validate if the SQLAlchemy exception is raised by the anticipated base psycopg exception class. This is necessary because a SQLAlchemy exception inherits multiple psycopg exceptions within the same class hierarchy.

Video showcasing the new behavior

Screen.Recording.2024-03-15.at.1.46.43.PM.mp4

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901 Anish9901 added the pr-status: review A PR awaiting review label Mar 15, 2024
@Anish9901 Anish9901 added this to the v0.1.6 milestone Mar 15, 2024
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@mathemancer mathemancer added this pull request to the merge queue Mar 15, 2024
Merged via the queue into develop with commit a6d5cd9 Mar 15, 2024
24 checks passed
@mathemancer mathemancer deleted the fix_schema_creation_failure branch March 15, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New connection creation flow does not handle schema creation failure scenarios
3 participants