Fix schema creation errors while adding a new connection #3490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3420
Technical details
It seems like Brent already had this potential failure in mind while working on implementing Connection RPC endpoints and the error handling was appropriately added. The exception class added however was the base exception for the underlying SQLAlchemy exception that was being generated, as detailed in the issue. This PR aims to improve this behavior by catching the specific SQLAlchemy exception rather than its base. Additionally, we validate if the SQLAlchemy exception is raised by the anticipated base psycopg exception class. This is necessary because a SQLAlchemy exception inherits multiple psycopg exceptions within the same class hierarchy.
Video showcasing the new behavior
Screen.Recording.2024-03-15.at.1.46.43.PM.mp4
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin