Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo target to Dockerfile #3523

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Add demo target to Dockerfile #3523

merged 2 commits into from
Apr 1, 2024

Conversation

mathemancer
Copy link
Contributor

@mathemancer mathemancer commented Mar 29, 2024

Fixes #3522

This adds a build stage to the Dockerfile for version 0.1.6, and adds a setting to fix the issue #3497 , but in the demo setting.

Edit: Now the default build is production, other targets work as expected.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer requested a review from pavish March 29, 2024 16:19
@mathemancer mathemancer added this to the v0.1.7 milestone Mar 29, 2024
@mathemancer mathemancer marked this pull request as draft March 29, 2024 16:21
@mathemancer
Copy link
Contributor Author

@pavish I converted this to draft, since we may want to change the approach.

@mathemancer
Copy link
Contributor Author

It would violate DRY, but couldn't we just base prod and demo off of the base in the same way, copy the build from develop into both, etc.? Then if production was last in the file, it would be the one produced by default (I think).

@mathemancer
Copy link
Contributor Author

Okay, I reordered things so production should be the default. I'm going to double-check that everything works as expected, and then mark this ready for review.

@mathemancer mathemancer marked this pull request as ready for review March 29, 2024 16:51
@mathemancer mathemancer added the pr-status: review A PR awaiting review label Mar 29, 2024
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathemancer Looks good to me!

@pavish pavish added this pull request to the merge queue Apr 1, 2024
Merged via the queue into develop with commit 43aeeec Apr 1, 2024
36 checks passed
@pavish pavish deleted the demo_fix_016 branch April 1, 2024 05:53
@seancolsen seancolsen mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo is broken for 0.1.6
2 participants