-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add columns.list
function
#3556
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
115485d
add initial db connection getting stub
mathemancer aeaab4f
Merge branch 'architectural_overhaul' into permissions_stub
mathemancer 518b7e1
first pass at functions to build the type_options JSON
mathemancer 6cb7ba0
add column info getting function and utils
mathemancer 96338c7
use different style to denote arrays, clean up code
mathemancer 2904112
add/improve docstrings of column info getter SQL functions
mathemancer 66ff45c
remove dependency on mathesar_types existing
mathemancer c2e9df5
add SQL tests for interval field builder
mathemancer a6c2983
test get_type_options function, fix bug
mathemancer cee460b
add tests for textual type options
mathemancer 1d465b8
move some setup functions into callers for efficiency
mathemancer fd3077e
move remaining setup functions into callers for efficiency
mathemancer d44c0b8
add get_column_info test
mathemancer 31829ae
add column info getter in python layer
mathemancer 993ee06
wire column info getter up to RPC endpoint
mathemancer 784276c
remove valid_target_types as it should go somewhere global
mathemancer 77ed379
fix typo in docstring
mathemancer b2f15ac
add class to validate and describe column info response
mathemancer 2c15a07
stub out permissions checks
mathemancer 45f3994
add classes to specify type options and defaults
mathemancer 41ff1b2
add class describing return value overall
mathemancer 4f585cd
add tests for wiring of RPC functions
mathemancer 3a5a394
move permission check to display_option function
mathemancer b7c91d1
add test for column lister RPC function
mathemancer 68b5ce0
fix linting issues
mathemancer 9278b6f
reduce test scope, improve focus
mathemancer 847ded4
add test for wiring of column info getter to DB
mathemancer 6169653
document fixtures in test_columns.py
mathemancer 7740f76
fix fixture name typo
mathemancer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing!!!