Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tables.add rpc endpoint #3614

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Implement tables.add rpc endpoint #3614

merged 6 commits into from
Jun 11, 2024

Conversation

Anish9901
Copy link
Member

@Anish9901 Anish9901 commented Jun 5, 2024

Fixes #3613

tables.add allows for creating an empty mathesar table, or a table with predefined columns and constraints. It doesn't however, allow creating a table via import, we'll have a separate endpoint(table.import) for being able to add a table via import.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901 Anish9901 marked this pull request as ready for review June 10, 2024 20:47
@Anish9901 Anish9901 added the pr-status: review A PR awaiting review label Jun 10, 2024
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work!

created_table_oid = create_table_on_database(
table_name, schema_oid, conn, column_data_list, constraint_data_list, comment
)
return created_table_oid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to enhance this return value. The current endpoint returns a blob describing the created table whenever one is created. OTOH, the only info in the blob we have set up for tables.list which wouldn't have been directly submitted is the OID, which this does return.

Let's merge as-is, and keep a mental note to watch for feature requests from the front end on this.

@@ -74,6 +74,28 @@ def from_dict(cls, col_default):
)


class CreateableColumnInfo(TypedDict):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we need to figure out a way to use inheritance here in a way that preserves the documentary value of these classes.

@mathemancer mathemancer added this pull request to the merge queue Jun 11, 2024
Merged via the queue into develop with commit cd4d299 Jun 11, 2024
37 checks passed
@mathemancer mathemancer deleted the table_add branch June 11, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tables.add RPC method
2 participants