Explicitly use as="text" when using httr::content
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`httr::content` automatically parsed the JSON response from the withings API, so calling `jsonlite::fromJSON(out)` failed because `out` was already an object. This change enforces `httr::content` to read the content as a text string so we can use `fromJSON` to parse the json.
fjukstad
changed the title
as="text" when using httr::content
|
Hey! Thanks so much for getting in touch, and thanks for already figuring out the issue! I see that I get the same error now on my old code that used to work, and it's all resolved by your PR on my machine too. I guess it must have to do with the latest updates to httr. This is really awesome! I'll just merge directly! Thanks again!! All the best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thanks for the great package!
I had some issues using it, getting the error
when using any of the
get-methods. I did some debugging and figured out that it was becausehttr::contentautomatically parsed the JSON response from the withings API, so subsequent calls tojsonlite::fromJSON(out)failed becauseoutwasalready an object.
Anyways, I've added the option to explicitly use
textwhen reading the content from the response. This fixed the issue for me.Cheers,
Bjørn