Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Importing and Crashing. #13

Closed
Electro18 opened this issue Jun 28, 2022 · 2 comments
Closed

Problem with Importing and Crashing. #13

Electro18 opened this issue Jun 28, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Electro18
Copy link

Electro18 commented Jun 28, 2022

worldometer.current_world_population()
Traceback (most recent call last):
File "", line 1, in
NameError: name 'worldometer' is not defined
from worldometer import Worldometer
Traceback (most recent call last):
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/worldometer/core.py", line 234, in _get_html
self.__r.html.render(timeout=self.__timeout)
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/requests_html.py", line 586, in render
self.browser = self.session.browser # Automatically create a event loop and browser
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/requests_html.py", line 730, in browser
self._browser = self.loop.run_until_complete(super().browser)
File "/nix/store/2vm88xw7513h9pyjyafw32cps51b0ia1-python3-3.8.12/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
return future.result()
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/requests_html.py", line 714, in browser
self._browser = await pyppeteer.launch(ignoreHTTPSErrors=not(self.verify), headless=True, args=self.__browser_args)
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/pyppeteer/launcher.py", line 307, in launch
return await Launcher(options, **kwargs).launch()
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/pyppeteer/launcher.py", line 168, in launch
self.browserWSEndpoint = get_ws_endpoint(self.url)
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/pyppeteer/launcher.py", line 227, in get_ws_endpoint
raise BrowserError('Browser closed unexpectedly:\n')
pyppeteer.errors.BrowserError: Browser closed unexpectedly:

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "", line 1, in
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/worldometer/init.py", line 84, in
from .api import *
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/worldometer/api.py", line 108, in
__w = Worldometer()
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/worldometer/core.py", line 181, in init
self._metrics = self.collect_metrics()
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/worldometer/core.py", line 300, in collect_metrics
html = self._get_html(url=URL)
File "/home/runner/Worldmeter/venv/lib/python3.8/site-packages/worldometer/core.py", line 239, in _get_html
raise Exception(err)
Exception: Browser closed unexpectedly:

This is the error

@Kabewh
Copy link

Kabewh commented May 22, 2023

Did you find a fix to this? Thanks

@matheusfelipeog matheusfelipeog added the bug Something isn't working label Oct 22, 2023
@matheusfelipeog
Copy link
Owner

Hi @Electro18 and @Kabewh,

Thank you for opening this issue, and I apologize for the delay in responding to it.

I've made a significant update to this project to address most of the recurring issues. This update introduces a new API (the old one is deprecated and will be removed in the future), new datasets, and updated documentation.

If you are still interested in this package and the collected data, you can check it out in version >=2.0.0 on PyPI.

If there are any other issues, please open them, and I will review them as soon as possible.

matheusfelipeog added a commit that referenced this issue Oct 25, 2023
## Added

- **New module structure (#22)**
   - new scraper module;
   - new world module for public api;
   - get home page counters, like in the old api, but now having a special data class;
   - get population and geography data;
   - set new dependencies;
   - new mapped pages;
   - add some tests.
- **Add docstrings to the new api (#23)**
- **Define explicit fields in all counter dataclasses (#26)**

## Changed

- **Reformulation of all docs (#24)**
   - new fully documented API;
   - new package logo and icon.
 - **Use the new API in the old core module. This is a temporary measure until the module is completely removed. (#25)**
    - warn about the deprecation of the old API and indicate the use of the new one.
- **Update all project metadata (#27)**
- **Change package manager and add action to run tests (#29)**
- **Support only Python `>=3.9, <3.12` (#29)**

## Removed

- **Removed support for Python 3.7 and 3.8 (#29)**

## Deprecated

- **`worldometer.core` and `worldometer.api` deprecated (#25)**

## Fixed

- **Fix old API (#25)**
   - fix: import "requests_html" could not be resolved (#12)
   - fix: problem with Importing and Crashing (#13)
   - fix: issue with "sanitize_metrics" method (#18)
   - fix: navigation Timeout Exceeded Error (#20)
   - fix: import error (#21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants