Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #4

Merged
merged 14 commits into from Mar 12, 2023
Merged

Fix CI #4

merged 14 commits into from Mar 12, 2023

Conversation

liuyangc3
Copy link
Contributor

No description provided.

@liuyangc3
Copy link
Contributor Author

liuyangc3 commented Mar 10, 2023

Hi @matheusgomes28 I've fixed the pipeline also, I don't have an Azure account, so I can only test on your repo, please squash commits before merge. :)

@matheusgomes28 matheusgomes28 merged commit 1314148 into matheusgomes28:main Mar 12, 2023
@matheusgomes28
Copy link
Owner

@liuyangc3 Once again, thank you for these fixes! I've slightly modified some commits to remove unnecessary code, and to make use of the new docker images I created for this repo.

With your issue recommendations I've decided to give this branch a little more work and turn it into a useful library people can actually use :)

I'll need to make some conan and vcpkg recipes for it in the future. Let me know if you have any other suggestions!

@liuyangc3 liuyangc3 deleted the patch-1 branch March 13, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants