Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clean Code] Use global Dictionary #22

Open
5 tasks
matheusinacio7 opened this issue May 10, 2021 · 0 comments
Open
5 tasks

[Clean Code] Use global Dictionary #22

matheusinacio7 opened this issue May 10, 2021 · 0 comments
Labels
optimization Improvements to code quality or run speed.

Comments

@matheusinacio7
Copy link
Owner

matheusinacio7 commented May 10, 2021 •
edited
Loading

Currently each component that is using the Dictionary class is importing it individually.

All components should use just one single Dictionary, which should available through the global GameContext.

  • Create global Dictionary in Game Context
  • Remove from the following components:
    • Info.tsx
    • Game.tsx
    • RankUp.tsx
@matheusinacio7 matheusinacio7 added the optimization Improvements to code quality or run speed. label May 10, 2021
@matheusinacio7 matheusinacio7 mentioned this issue May 10, 2021
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization Improvements to code quality or run speed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matheusinacio7