Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for auto switch URL. #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gucong3000
Copy link

@gucong3000 gucong3000 commented Aug 22, 2018

Closes #60

@codecov-io
Copy link

codecov-io commented Aug 22, 2018

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files           2        2           
  Lines          66       66           
=======================================
  Hits           61       61           
  Misses          5        5
Impacted Files Coverage Δ
index.js 90.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777d7db...06103bd. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 92.424% when pulling 06103bd on gucong3000:auto_switch_url into 777d7db on matheuss:master.

Copy link

@rawr51919 rawr51919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be anything breaking this API when this code is allowed, and from the looks of this code, it'll help greatly. I approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants