Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline regexpu-fixtures #84

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

JLHwung
Copy link
Collaborator

@JLHwung JLHwung commented Sep 19, 2023

The motivation of regexpu-fixtures is to share the Unicode related regex test cases with other libraries or implementations. Through time it causes maintenance frictions because of the long cycle of adding a new Unicode test cases: add to the repo → publish regexpu-fixtures → update the package.json here. It might explain why the fixtures of new features, such as property escapes, named groups, etc. are not placed in the regexpu-fixtures package.

In this PR we inline the regexpu-fixtures package. I suggest also archive that library. For users of regexpu-fixtures, they can clone this repo and import unicodeFixtures from ./tests/fixtures/unicode.js, plus they can now access more fixtures for other Unicode-related regex features.

tests/tests.js Outdated
const FLAGS_WITHOUT_UNICODE = ' i g m y ig im igm igmy'.split(' ');
const FLAGS = FLAGS_WITH_UNICODE.concat(FLAGS_WITHOUT_UNICODE);

const unicodeFixtures = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we still pull it into a separate files, that users can easily replace regexpu-fixtures with regexpu-core/tests/regexpu-fixtures.js?

@JLHwung JLHwung mentioned this pull request Sep 19, 2023
@nicolo-ribaudo nicolo-ribaudo merged commit fa70523 into mathiasbynens:main Sep 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants