Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for encoding to and decoding from byte arrays #28

Closed
wants to merge 7 commits into from

Conversation

samal-rasmussen
Copy link

This is a solution for #7

@coveralls
Copy link

coveralls commented May 29, 2017

Coverage Status

Coverage increased (+0.5%) to 98.026% when pulling c783ad6 on samal84:master into 2ce0954 on mathiasbynens:master.

@samal-rasmussen
Copy link
Author

It seems the build is failing because the build server's js environment doesn't support the Uint8Array type. Should I add a commit with feature detection for Uint8Array?

Repository owner deleted a comment from coveralls Jun 15, 2017
Repository owner deleted a comment from coveralls Jun 15, 2017
@wayofthefuture
Copy link

wayofthefuture commented Nov 19, 2017

+1 Would be nice to have this feature....

@samal-rasmussen
Copy link
Author

I've fixed up this branch so it builds again. The implementation is a bit cleaner too.

@samal-rasmussen
Copy link
Author

Time flies and TextEncoder/TextDecoder are now widely supported in js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants