This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
Fix NoStacktraceFormatter #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deals with a surprising gotcha in Python's logging system: the result of formatException() is cached. If you want to ensure that a custom formatException method is called, you need to explicitly clear the exc_text attribute in format(). This is documented behavior, see https://bugs.python.org/issue29056 for background info. In our setup, we had an earlier handler with a default formatter, so NoStacktraceFormatter's method was entirely ignored.
mathiasose
approved these changes
Feb 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with a surprising gotcha in Python's logging system: the
result of formatException() is cached. If you want to ensure that a
custom formatException method is called, you need to explicitly clear
the exc_text attribute in format().
This is documented behavior, see https://bugs.python.org/issue29056
for background info.
In our setup, we had an earlier handler with a default formatter, so
NoStacktraceFormatter's method was entirely ignored.