Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Team, Formula enums #13

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

Alintya
Copy link
Contributor

@Alintya Alintya commented Oct 31, 2023

No description provided.

Copy link
Owner

@mathieu-lemay mathieu-lemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good to me. Just the F221 that is not super readable, I'd change that.

I'm just curious where did you find the values? I don't see them in the latest documentation.

Beta,
Supercars,
Esports,
F221,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename to F2_21? I just think it's hard to read without the underscore.

@Alintya
Copy link
Contributor Author

Alintya commented Nov 1, 2023

The formula values are actually in the official doc, except for word car.
The others were from the forum and trial&error
https://answers.ea.com/t5/General-Discussion/F1-23-UDP-Specification/td-p/12632888/page/14

@mathieu-lemay mathieu-lemay merged commit 86508f8 into mathieu-lemay:master Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants