Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: "Install with Sketch Runner" #103

Closed
wants to merge 6 commits into from
Closed

Added: "Install with Sketch Runner" #103

wants to merge 6 commits into from

Conversation

nikolasklein
Copy link

Hey there Mathieu,
I've just added a screenshot and a description showing that Git is now easily accessible in Runner. Hope that's ok. ✌️

@mathieudutour
Copy link
Owner

hum what is sketch runner doing to install it?

@nikolasklein
Copy link
Author

nikolasklein commented Apr 5, 2017

Runner is downloading the Git.sketchplugin file in your main branch and moves this one into the Sketch Plugins Folder. Since I've installed it before, I thought it would just work.

I just checked it and it seems that your Git.sketchplugin folder which is in your root is not complete. It's missing the Sketch folder in Contents/. This is compared to your release bundle, that you can download on your website.

If you fix the bundle installing via Runner should work smoothly.

@mathieudutour
Copy link
Owner

No, I don't want to commit generated files. I foresee that more and more plugins will be generated like this one (javascript is compiled to cocoascript). There are tons of advantages (ES6+, eslint, npm ecosystem, etc.).

That's why I started a registry for sketch plugins: https://github.com/sketch-pm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants