Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the plugin compatible with the latest Sketch #23

Merged
merged 1 commit into from Oct 9, 2023

Conversation

rodionovd
Copy link
Contributor

@rodionovd rodionovd commented Oct 8, 2023

I believe this single change is enough to support at least Sketch 98 and 99 Beta. Addresses #18.


I'm also attaching a pre-built .sketchplugin for people to grab and test until this PR is landed and the official update is out:
import-svg-as-artboard.Sketch-98.sketchplugin.zip

@jazzybeat
Copy link

jazzybeat commented Oct 8, 2023

Hi Dmitry,

Thanks for taking your time to fix this Plugin. I tested it and I see an issue with layer placement position inside the artboard. Please see attached screenshot. If you need SVG icons for testing please use google icons.

Screenshot 2023-10-08 at 17 35 31

@rodionovd
Copy link
Contributor Author

Hi Dmitry,

Thanks for taking your time to fix this Plugin. I tested it and I see an issue with layer placement position inside the artboard. Please see attached screenshot. If you need SVG icons for testing please use google icons.

Aha, yep, some SVGs like that one seem to have issues with relative positioning when imported using this plugin. Unfortunately I can confirm the current version of the plugin also suffers from this problem (when running on a much older version of Sketch, that is).

While it's not really a Sketch compatibility thing, let me see what can be done to support such SVGs as well.

Copy link
Owner

@mathieudutour mathieudutour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants