Traverse nested PolymorphicEmbed errors #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit confused because of this line in the project's README:
Does this mean that it should already support If it's the other way around, I can update this PR to add support for nested |
|
@mathieuprog is there any chance you could follow up on this PR? I'm running into the same issue. Thanks! (Great work on the library btw) |
1 task
|
This has been added. Awesome work. Sorry it took so much time. Couldn't merge as there were conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
traverse_errors/2currently does not work, if thepolymorphic_embeds_*is nested inside an Ecto-native*-to-oneor*-to-manyassociation. These errors are never processed.This PR adds support for this.
Fixes #72