Keeping whitespaces for text nodes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyboer
commented
Jul 18, 2022
bennyboer
commented
Jul 18, 2022
| <div > Text </div> | ||
|
|
||
| <!-- Whitespaces in closing tag to the left (should not work) --> | ||
| <div> Text < /div> |
There was a problem hiding this comment.
Cases where </ is separated by a whitespace like < / do not work in browsers as well, so I just didn't make them work either
bennyboer
commented
Jul 18, 2022
| @@ -62,7 +62,7 @@ expression: dom | |||
| ], | |||
| "children": [ | |||
| "this is deep", | |||
| "hello world" | |||
| "hello world\n " | |||
There was a problem hiding this comment.
There are some cases where we get this ugly output. But this seems to be the same thing browsers do when you try to edit text nodes where they also seem to include line breaks and stuff.
Altogether I think this is the better behavior as you can just trim the result if you don't need the whitespaces.
|
Come on @mathiversen you marked my review comments as resolved without further comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #22
I was fiddling a little with pest to fix this problem. Unfortunately there is no easy fix as the problem occurs when using implicit whitespaces. We can avoid the problem by using atomic rules. Unfortunately the rules we'd need to make atomic are also silent and there is no solution for atomic and silent rules yet (see pest-parser/pest#520). There is also a discussion changing whitespace handling alltogether where some people recommended just not relying on implicit whitespaces and rather doing is explicitely. With this PR I tried to do that and added some tests to verify the whitespace parsing behavior.
WHITESPACErule to avoid pests implicit whitespace handlingWSPrule explicitely where is makes senseTests are all green, so I am pretty confident that everything works as expected. Unfortunately I am a pest newbie. Therfore if you could review the rewritten grammar that would be pretty great!
Thanks!