-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turning mjsingle and mjpage into a single library #45
Comments
The main configuration options for the two libraries are completely different, and so you would end up with a library that has two basically separate sets of configuration paths and two internal processing paths. I don't see the win to that. It seems to me that this unnecessarily complicates the internals of the library for the small gain of sharing the initialization functions. If we really want to share those, it might be better to pull them into a common file loaded by both libraries. I think we are still learning what the use-cases for MathJax-node are going to be, and I suspect that a redesign of the mj-page interface in particular may be something that we should think about when we have a better idea of the uses that it is going to put to. So I would not want to move too quickly to combine the two separate interfaces. |
Thanks, Davide. I didn't expect bigger problems but it turns out I'm wrong. My thinking was that But let's shelf it for the time being. |
I'm sure it is possible. The question is what are the trade-offs in doing it. A single file is always nice, but if it is more complicated, perhaps that out ways the benefit.
Sounds good. I think things are still settling in with MathJax-node. It might mean that we don't get to merge all pull requests, however, until we settle on a more clear sense of what the API needs to include, depending on the contents of the pull request. |
Closed in favor of #206 |
It seems to me
mjpage
could be coaxed to producemjsingle
output, so that a configuration option might be enough. What am I missing?The text was updated successfully, but these errors were encountered: