Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core support #386

Closed
chaliy opened this issue Apr 2, 2016 · 17 comments
Closed

.NET Core support #386

chaliy opened this issue Apr 2, 2016 · 17 comments
Assignees

Comments

@chaliy
Copy link

chaliy commented Apr 2, 2016

Hello, is there any plans to support .NET Core?

@cdrnet
Copy link
Member

cdrnet commented Apr 3, 2016

To my understanding, in theory our PCL profile 259 is supposed to be supported by .Net Core. Unfortunately I had to stop my experiments, among others due to blocking .Net Native bugs (#361). Also, our PCL builds have some limitations including the lack of support for native providers.

We certainly want to support .Net Core, properly, including native providers. Ideally we could add a build targetting one of the new netstandard 1.x monikers. Maybe this could be based on an earlier PoC in #265.

@ericstj
Copy link

ericstj commented Jun 30, 2016

Let me know if you'd like some help with this. I see you have a net45+win8+wp8+wpa81 project which maps to netstandard1.0. You could reuse this build and merely package it with its dependencies, which I see would be:

      <group targetFramework=".NETStandard1.0">
        <dependency id="NETStandard.Library" version="1.6.0" />
        <dependency id="System.Runtime.Serialization.Primitives" version="4.1.1" />
      </group>

@cdrnet cdrnet self-assigned this Jul 1, 2016
@ghost
Copy link

ghost commented Jul 6, 2016

I'd also like to see this soon, as I'm helping with porting documentation at tryfsharp to the .net core site repo and we used this package to demonstrate its use in stocks.

@cdrnet
Copy link
Member

cdrnet commented Jul 6, 2016

Just to clarify, by reusing the PCL-259 (net45+win8+wp8+wpa81) build you mean the build configuration or even the compiled assembly? And then copy that assembly to lib\netstandard1.0 in the NuGet package and declare the additional dependencies for the .NETStandard1.0 group?

@affans
Copy link

affans commented Jul 20, 2016

@cdrnet Would @ericstj 's solution work? Are there dependencies in the project that .net core libraries may not have?

@ericstj
Copy link

ericstj commented Jul 25, 2016

build you mean the build configuration or even the compiled assembly? And then copy that assembly to lib\netstandard1.0 in the NuGet package and declare the additional dependencies for the .NETStandard1.0 group?

Yeah, that will work work as a quick fix. If you change your dependencies you should update the list, but given this is a low-level math library I don't expect your dependencies change very often.

@Hugh-walsh
Copy link

Now that Visual studio 2017 is out we would really like this functionality as .net core is required for docker support which in turn gives us a more scale-able solution is anyone still working on this?

@stefanks
Copy link

stefanks commented Apr 3, 2017

Also interested in the current status.

LHCGreg added a commit to LHCGreg/animerecs that referenced this issue Jun 28, 2017
Unfortunately MyMediaLite's dependencies, C5 and and MathNet.Numerics,
do not yet have netstandard packages.

C5 has an open issue and a PR for it:
* sestoft/C5#55
* sestoft/C5#50

MathNet.Numerics has two open issues for it:
* mathnet/mathnet-numerics#421
* mathnet/mathnet-numerics#386

In both cases the maintainer seems interested in supporting
netstandard but wants to wait for the dust to settle a bit more.

I have contributed to packaging MyMediaLite so I can help it
target netstandard once C5 and MathNet.Numerics have a netstandard
target, assuming the MyMediaLite maintainer is ok with any changes
required.

But for now, animerecs does not really use MyMediaLite other than
as an undocumented recommendation algorithm accessible by changing
the URL. So removing support for it is the quickest path to
migrating animerecs to .NET core.
LHCGreg added a commit to LHCGreg/animerecs that referenced this issue Jun 29, 2017
MyMediaLite and its dependencies, C5 and MathNet.Numerics, do not
yet have netstandard packages.

C5 has an open issue and a PR for it:
* sestoft/C5#55
* sestoft/C5#50

MathNet.Numerics has two open issues for it:
* mathnet/mathnet-numerics#421
* mathnet/mathnet-numerics#386

In both cases the maintainer seems interested in supporting
netstandard but wants to wait for the dust to settle a bit more.

I have contributed to packaging MyMediaLite so I can help it
target netstandard once C5 and MathNet.Numerics have a netstandard
target, assuming the MyMediaLite maintainer is ok with any changes
required.

This is not a big deal as animerecs does not really use MyMediaLite
other than as an undocumented recommendation algorithm accessible by
changing the URL.

Pull in the MedallionRandom package for the Shuffle method to use in
place of MyMediaLite's implementation.
@gentisaliu
Copy link

Also interested in the current status and would very much need .NET Core support.

@karlra
Copy link

karlra commented Aug 19, 2017

Same here, could someone summarize what is required to achieve this so that the community can help?

@ghost
Copy link

ghost commented Aug 20, 2017

.NET Core 2.0 is out, presumably .NET Standard and it's new classes are out too.

@DenisBabarykin
Copy link

@cdrnet, are there any plans to do this soon? Can we count on it?

@cdrnet
Copy link
Member

cdrnet commented Sep 25, 2017

Yes (.Net Standard 2.0).

@narciero
Copy link

is there an ETA for .NET Core support?

@cdrnet
Copy link
Member

cdrnet commented Dec 12, 2017

Closing this, since the first alpha releases of v4 with .Net Standard 1.3/2.0 support are out. Please let me know if you have any issues. Thanks a lot for your contributions!

@cdrnet cdrnet closed this as completed Dec 12, 2017
@cdrnet cdrnet added this to the Numerics v4.0 milestone Feb 8, 2018
@lloydjatkinson
Copy link

You may wish to consider listing .NET Core support on the homepage. For example https://numerics.mathdotnet.com/Compatibility.html doesn't mention Core or Standard anywhere.

@cdrnet
Copy link
Member

cdrnet commented Sep 2, 2018

Thanks for the hint! I've updated the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests