New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring F# PowerPack's Complex & BigRational and FSharpx's DistributionMonad #61
Conversation
Thanks a lot! Some notes (I can help): System.Numerics and portable builds Complex Numbers Portable Project Distribution Monad Thanks, |
Updated the pull request with: On another note, the FSharp tests are being run as a console application. The ones I've added use NUnit. Are you running the tests in CI? I couldn't find a build script to update it to run the new NUnit tests |
Great, thanks! Unit Tests: The main unit tests are fully integrated, but not yet the F# ones. We better convert all of them to NUnit as well, then I'll add another build step for them in TeamCity. |
I'm converting the unit tests |
Done. Any more feedback? |
rather than type 'a RandomVariable Idiomatic F# code generally only uses prefix arguments for "list", "option", "[]" and "ref" (if at all).
Thanks |
Also,
|
Humm, I though the portable version for FSharp.Core didn't have the BigInteger, but while checking again it seems it has, only Parse is missing. I'll revise |
….Numerics namespace
…e method in Portable version
Fixed |
Looking at https://github.com/fsharp/fsharp/blob/master/src/fsharp/FSharp.Core/math/z.fsi#L44 I think BigInteger.Parse is there, but not the culture-aware version taking three arguments. |
Yes, in the source code it appears so, but in the actual dll (Program Files\Reference Assemblies\Microsoft\FSharp\3.0\Runtime.NETPortable\FSharp.Core.dll) it's not. |
FYI, I've enabled the F# unit tests in TeamCity, works nicely. Thanks again. |
This is related to #60
We want to not have Math stuff on FSharpx and instead contribute it to Math.Net
The INumerics interface and matrix classes from PowerPack are also interesting to port over, but that needs more work as there's overlap. I'll suggest something in a couple of days