Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\text{} element alone in editor not serialized with .latex() unless other math symbols included #794

Closed
jaltekruse opened this issue Jan 30, 2018 · 7 comments
Assignees

Comments

@jaltekruse
Copy link
Contributor

image

I haven't been able to confirm this is failing in the serialization process. This might also be an issue with not receiving an edited event when pressing enter to create the text sub-box. For example like in the GIf above: \asdf [enter] (I think it is fine to not get edited events while users may still be typing in a latex symbol).

This bug is making me less confident about exposing any of the latex symbols that require a backslash prefix to users in my app (without making them auto-symbols), as mistyping a symbol creates one of these text elements. Given the current structure of my app this can clear what user types in Mathquill fields. I am using a React wrapper from the Khan team that causes a re-render event based on the current app state on blur, so I need to have up-to-date latex for what is in the field when something loses focus. I'll file an issue over there as well to see if they have any ideas about possible workarounds.

@jaltekruse
Copy link
Contributor Author

I guess github doesn't support gifs, here's a link: http://gph.is/2GvI62q

@surenk6
Copy link

surenk6 commented Feb 13, 2018

I have encountered this issue as well. I am using this product in development. Please give a solution to this issue asap.

@narek-sv
Copy link

This is annoying, please fix it as fast as possible!!!

@vuvkar
Copy link

vuvkar commented Feb 13, 2018

Yeah, me too. isn't there any temporary solution guys? :/

@VahanArsenyan
Copy link

Same problem :( so sad about it. Pls solve it guys :(

@ArevikDev
Copy link

Same here

@jaltekruse
Copy link
Contributor Author

It can be very frustrating as a maintainer to have users that are certain that their problems are the most important for the project. If this is such a big problem for all of us we can put some of our own effort into trying to address it. I was just reporting the issue to see if I could get some help from others more familiar with the codebase. Please keep this in mind when you are commenting on issues and feature requests in the future.

Several of your responses are fine to report running into this problem as well, but insisting this needs to be resolved ASAP and accusing the maintainers of not prioritizing this correctly gets old fast.

@laughinghan laughinghan self-assigned this May 1, 2020
laughinghan added a commit that referenced this issue May 21, 2020
Fix #794: TextBlocks dispatch reflow at the wrong time
kschaefe pushed a commit to CarnegieLearningWeb/mathquill that referenced this issue Sep 22, 2020
Also fix mathquill#705, supersede and close mathquill#847

Reflow should obviously dispatch after the contents of the TextBlock is
populated, commit log doesn't show any reason it was placed before, it's
been that way since text was refactored into TextBlock:
mathquill@c4ba683#diff-d7064a7fc8599c06242c4c9ba3264fdbR28

Similarly after writing a character in TextBlock, should clearly
dispatch a reflow, but it hasn't from the beginning:
mathquill@c4ba683#diff-d7064a7fc8599c06242c4c9ba3264fdbR98

Also:
- update demo.html to use edit handlers, since we tell API clients to
- update typing and text test suites to check LaTeX-during-edit-event,
  piggybacking on current LaTeX checks

Recommend -w to view diff.
Dantica pushed a commit to kedyou/mathquill that referenced this issue Sep 25, 2020
Also fix mathquill#705, supersede and close mathquill#847

Reflow should obviously dispatch after the contents of the TextBlock is
populated, commit log doesn't show any reason it was placed before, it's
been that way since text was refactored into TextBlock:
mathquill@c4ba683#diff-d7064a7fc8599c06242c4c9ba3264fdbR28

Similarly after writing a character in TextBlock, should clearly
dispatch a reflow, but it hasn't from the beginning:
mathquill@c4ba683#diff-d7064a7fc8599c06242c4c9ba3264fdbR98

Also:
- update demo.html to use edit handlers, since we tell API clients to
- update typing and text test suites to check LaTeX-during-edit-event,
  piggybacking on current LaTeX checks

Recommend -w to view diff.
Dantica pushed a commit to kedyou/mathquill that referenced this issue Sep 25, 2020
Fix mathquill#794: TextBlocks dispatch reflow at the wrong time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants