Skip to content

Commit

Permalink
fix: Changed CardTile height specifications.
Browse files Browse the repository at this point in the history
  • Loading branch information
mathrunet committed Nov 1, 2023
1 parent 51b1005 commit 5893512
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 12 deletions.
8 changes: 4 additions & 4 deletions packages/katana_ui/example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -353,14 +353,14 @@ packages:
path: "../../katana"
relative: true
source: path
version: "2.4.2"
version: "2.4.3"
katana_ui:
dependency: "direct main"
description:
path: ".."
relative: true
source: path
version: "2.5.2"
version: "2.5.4"
lints:
dependency: transitive
description:
Expand Down Expand Up @@ -610,10 +610,10 @@ packages:
dependency: transitive
description:
name: uuid
sha256: "648e103079f7c64a36dc7d39369cabb358d377078a051d6ae2ad3aa539519313"
sha256: b715b8d3858b6fa9f68f87d20d98830283628014750c2b09b6f516c1da4af2a7
url: "https://pub.dev"
source: hosted
version: "3.0.7"
version: "4.1.0"
vector_math:
dependency: transitive
description:
Expand Down
9 changes: 4 additions & 5 deletions packages/katana_ui/lib/ui/card_tile.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
part of katana_ui;

const kCardHeight = 196.0;

/// A widget for displaying an image or text over a card widget.
///
/// Use in conjunction with [ListTile].
Expand All @@ -21,7 +19,7 @@ class CardTile extends StatelessWidget {
super.key,
this.onTap,
this.width,
this.height = kCardHeight,
this.height,
this.feature,
this.backgroundColor,
this.shadowColor,
Expand Down Expand Up @@ -53,7 +51,7 @@ class CardTile extends StatelessWidget {
/// The height of the card.
///
/// カードの縦幅。
final double height;
final double? height;

/// Feature widget to display.
///
Expand Down Expand Up @@ -176,7 +174,8 @@ class CardTile extends StatelessWidget {
mainAxisAlignment: MainAxisAlignment.end,
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
if (feature != null) Expanded(child: feature!),
if (feature != null)
if (height != null) Expanded(child: feature!) else feature!,
ListTile(
title: title,
mouseCursor: SystemMouseCursors.click,
Expand Down
6 changes: 3 additions & 3 deletions packages/katana_ui/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ packages:
path: "../katana"
relative: true
source: path
version: "2.4.3"
version: "2.5.0"
lints:
dependency: transitive
description:
Expand Down Expand Up @@ -470,10 +470,10 @@ packages:
dependency: transitive
description:
name: uuid
sha256: "648e103079f7c64a36dc7d39369cabb358d377078a051d6ae2ad3aa539519313"
sha256: b715b8d3858b6fa9f68f87d20d98830283628014750c2b09b6f516c1da4af2a7
url: "https://pub.dev"
source: hosted
version: "3.0.7"
version: "4.1.0"
vector_math:
dependency: transitive
description:
Expand Down

0 comments on commit 5893512

Please sign in to comment.