fix: Allow overwrite_rule to be specified.

mathrunet · Jun 30, 2023 · adb14da · adb14da
1 parent e3a2281
commit adb14da
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 8 deletions.
diff --git a/packages/katana_cli/lib/action/firebase/init.dart b/packages/katana_cli/lib/action/firebase/init.dart
@@ -60,13 +60,16 @@ class FirebaseInitCliAction extends CliCommand with CliActionMixin {
     final projectId = firebase.get("project_id", "");
     final hosting = firebase.getAsMap("hosting");
     final useFlutter = hosting.get("use_flutter", false);
-    final enabledFirestore =
-        firebase.getAsMap("firestore").get("enable", false);
+    final firestore = firebase.getAsMap("firestore");
+    final overwriteFirestoreRule = firestore.get("overwrite_rule", false);
+    final enabledFirestore = firestore.get("enable", false);
     final enabledAuthentication =
         firebase.getAsMap("authentication").get("enable", false);
     final enabledFunctions =
         firebase.getAsMap("functions").get("enable", false);
-    final enabledStorage = firebase.getAsMap("storage").get("enable", false);
+    final storage = firebase.getAsMap("storage");
+    final overwriteStorageRule = storage.get("overwrite_rule", false);
+    final enabledStorage = storage.get("enable", false);
     final enabledHosting = hosting.get("enable", false);
     final enabledLogger = firebase.getAsMap("logger").get("enable", false);
     final enableActions = enableGithubAction &&
@@ -212,8 +215,10 @@ class FirebaseInitCliAction extends CliCommand with CliActionMixin {
           );
         });
         await firestoreProcess.exitCode;
-        label("Rewriting Rules");
-        await const FirestoreRulesCliCode().generateFile("firestore.rules");
+        if (overwriteFirestoreRule) {
+          label("Rewriting Rules");
+          await const FirestoreRulesCliCode().generateFile("firestore.rules");
+        }
       }
     }
     if (enabledStorage) {
@@ -247,8 +252,11 @@ class FirebaseInitCliAction extends CliCommand with CliActionMixin {
           );
         });
         await storageProcess.exitCode;
-        label("Rewriting Rules");
-        await const FirebaseStorageRulesCliCode().generateFile("storage.rules");
+        if (overwriteStorageRule) {
+          label("Rewriting Rules");
+          await const FirebaseStorageRulesCliCode()
+              .generateFile("storage.rules");
+        }
       }
     }
     if (enabledHosting) {

diff --git a/packages/katana_cli/lib/config.dart b/packages/katana_cli/lib/config.dart
@@ -114,6 +114,7 @@ firebase:
   # Firebase Firestoreを有効にします。
   firestore:
     enable: false
+    overwrite_rule: false
 
   # Enable Firebase Authentication.
   # Firebase Authenticationを有効にします。
@@ -165,6 +166,7 @@ ${showAllConfig ? """
   # Cloud Storage for Firebaseを有効にします。
   storage:
     enable: false
+    overwrite_rule: false
 
   # Enable Cloud Functions for Firebase.
   # Cloud Functions for Firebaseを有効にします。

diff --git a/packages/katana_cli/pubspec.lock b/packages/katana_cli/pubspec.lock
@@ -159,7 +159,7 @@ packages:
       path: "../katana"
       relative: true
     source: path
-    version: "2.2.1"
+    version: "2.2.2"
   lints:
     dependency: "direct main"
     description: