Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Update for clan capital #115

Closed
wants to merge 6 commits into from

Conversation

doluk
Copy link
Collaborator

@doluk doluk commented Aug 24, 2022

Assuming the current bug with the level of each district hall gets fixed. This should be all to support the new stuff

(Some extra commits to exclude stuff from other pending pull requests)

Copy link
Owner

@mathsman5133 mathsman5133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Should we add a simple test to one of the integration tests since it's not a tiny change / uncommon use - with basic functionality?

coc/clans.py Outdated Show resolved Hide resolved
@doluk
Copy link
Collaborator Author

doluk commented Aug 24, 2022

we can add a test, but I have no time to code it. Sadly have to do other stuff. So somebody else would have to do it

@majordoobie
Copy link
Collaborator

I can do it tomorrow in the morning (0800 ET) if no one else can today.

@majordoobie
Copy link
Collaborator

Moved to #116

@majordoobie majordoobie mentioned this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants