Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: title is deleted when updateParameters() is called with no title #265

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

mathuo
Copy link
Owner

@mathuo mathuo commented Jun 5, 2023

No description provided.

@mathuo mathuo linked an issue Jun 5, 2023 that may be closed by this pull request
@mathuo mathuo force-pushed the 258-dockviewapitojson-doesnt-include-panel-titles-2 branch from ac9dcb8 to 0438f8c Compare June 5, 2023 19:26
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ac9dcb8:

Sandbox Source
constraints-dockview Configuration
customheader-dockview Configuration
demo-dockview Configuration
dnd-dockview Configuration
dockview-app Configuration
events-dockview Configuration
externaldnd-dockview Configuration
fullwidthtab-dockview Configuration
layout-dockview Configuration
nativeapp-dockview Configuration
nested-dockview Configuration
rendering-dockview Configuration
resize-dockview Configuration
resizecontainer-dockview Configuration
simple-dockview Configuration
tabheight-dockview Configuration
updatetitle-dockview Configuration
watermark-dockview Configuration
javascript-fullwidthtab-dockview Configuration
javascript-simple-dockview Configuration
javascript-tabheight-dockview Configuration
javascript-vanilla-dockview Configuration

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 78eac85:

Sandbox Source
constraints-dockview Configuration
customheader-dockview Configuration
demo-dockview Configuration
dnd-dockview Configuration
dockview-app Configuration
events-dockview Configuration
externaldnd-dockview Configuration
fullwidthtab-dockview Configuration
layout-dockview Configuration
nativeapp-dockview Configuration
nested-dockview Configuration
rendering-dockview Configuration
resize-dockview Configuration
resizecontainer-dockview Configuration
simple-dockview Configuration
tabheight-dockview Configuration
updatetitle-dockview Configuration
watermark-dockview Configuration
javascript-fullwidthtab-dockview Configuration
javascript-simple-dockview Configuration
javascript-tabheight-dockview Configuration
javascript-vanilla-dockview Configuration

@mathuo mathuo force-pushed the 258-dockviewapitojson-doesnt-include-panel-titles-2 branch 9 times, most recently from feeb259 to 115f728 Compare June 6, 2023 20:17
@mathuo mathuo force-pushed the 258-dockviewapitojson-doesnt-include-panel-titles-2 branch from 115f728 to 78eac85 Compare June 6, 2023 20:30
@mathuo mathuo merged commit 88565f0 into master Jun 6, 2023
3 checks passed
@mathuo mathuo deleted the 258-dockviewapitojson-doesnt-include-panel-titles-2 branch June 6, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DockviewApi.toJSON doesn't include panel titles
1 participant