Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH add weights to GroupLasso to provide support for an Adaptive GroupLasso #219

Closed
sehoff opened this issue Mar 4, 2022 · 5 comments · Fixed by #223
Closed

ENH add weights to GroupLasso to provide support for an Adaptive GroupLasso #219

sehoff opened this issue Mar 4, 2022 · 5 comments · Fixed by #223

Comments

@sehoff
Copy link

sehoff commented Mar 4, 2022

Hi,
thanks for this great package! Does the group-lasso method allow for different penalizations for different groups, such that one could fit an adaptive group lasso, i.e., applying different weights in the second call to the method? (reference for adapative group lasso: https://www.sciencedirect.com/science/article/abs/pii/S0167947308002582)

If not, would it be possible to extend the method (easily)?

Thank you.

@mathurinm
Copy link
Owner

Hi !
Thanks for the interest. The feature is not currently supported, but it's quite easy to implement a weights attribute that can be changed after each fit ad affects the strength of each penalty (as is currently done in the Lasso class). I should be able to implement it next week

@mathurinm mathurinm changed the title Adaptive GroupLasso ENH add weights to GroupLasso to provide support for an Adaptive GroupLasso Mar 4, 2022
@mathurinm
Copy link
Owner

(as long as you don't need some of these weights to be 0, because celer won't support that, see #185)

@sehoff
Copy link
Author

sehoff commented Mar 5, 2022

I really appreciate your fast answer and implementation. All my weights will be positive!

@cruyffturn
Copy link

Hi ! Thanks for the interest. The feature is not currently supported, but it's quite easy to implement a weights attribute that can be changed after each fit ad affects the strength of each penalty (as is currently done in the Lasso class). I should be able to implement it next week

I thought the celer_path allows group weights as it's indicated in here.

@mathurinm
Copy link
Owner

@cruyffturn thanks for pointing this out; it is a mistake in the docstring as weights are not passed to the solver inside the loop over alphas here: https://github.com/mathurinm/celer/blob/main/celer/homotopy.py#L296
#223 will fix this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants