Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP add weights to Group Lasso #220

Closed
wants to merge 2 commits into from
Closed

WIP add weights to Group Lasso #220

wants to merge 2 commits into from

Conversation

Badr-MOUFAD
Copy link
Collaborator

@Badr-MOUFAD Badr-MOUFAD commented Mar 6, 2022

closes #219

@codecov-commenter
Copy link

Codecov Report

Merging #220 (de64d55) into main (f7fa260) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   85.79%   85.80%   +0.01%     
==========================================
  Files          14       14              
  Lines         929      930       +1     
  Branches      128      128              
==========================================
+ Hits          797      798       +1     
  Misses        101      101              
  Partials       31       31              
Flag Coverage Δ
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celer/dropin_sklearn.py 95.71% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fa260...de64d55. Read the comment docs.

@mathurinm
Copy link
Owner

@Badr-MOUFAD you need to add a unit test to check that it works as expected, for example by comparing with a Lasso in the case where groups are of size 1. You can draw inspiration from the existing test on weights for the Lasso

@mathurinm mathurinm changed the title add weights to Group Lasso WIP add weights to Group Lasso Mar 7, 2022
@Badr-MOUFAD Badr-MOUFAD closed this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH add weights to GroupLasso to provide support for an Adaptive GroupLasso
3 participants