Added ServiceMonitor to facilitate Prometheus target discovery #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we need to disable the prometheus annotations when the servicemonitor is present. I know we didn't get any scraping in our test cluster without the servicemonitor, but it seems there could be situations where having both would result in double scraping: https://gitlab.com/gitlab-org/charts/gitlab-runner/-/issues/361 |
NBonfattiMW
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create ServiceMonitor conditionally if enabled in values.yaml and CRD is available (installed).
Tie ServiceMonitor to Prometheus deployment via configurable label-selection in values.yaml
Updated values.yaml inline comments and aligned indentation of inner template yaml file.
Tested the following Prometheus scenarios: