Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching persons on file is not compatible with fulltextsearch #263

Closed
DrRSatzteil opened this issue Apr 20, 2020 · 14 comments
Closed

Searching persons on file is not compatible with fulltextsearch #263

DrRSatzteil opened this issue Apr 20, 2020 · 14 comments

Comments

@DrRSatzteil
Copy link

DrRSatzteil commented Apr 20, 2020

Sorry if this has been answered somewhere else but I could not find it:

Expected behaviour

Searching in the files app is supposed to find pictures of tagged faces (as stated in README: "In the file application the user can search by typing your friend's name, and it will show all the photos.")

Actual behaviour

No pictures are found when searching for peoples names

Steps to reproduce

  1. Open Files app
  2. Search for a name that has been assigned to a face cluster
  3. Find nothing

Server configuration

Client configuration

  • Browser:
    Chrome

  • Operating system:
    Windows & Android

Logs

nothing of interest


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@matiasdelellis

This comment has been minimized.

@DrRSatzteil

This comment has been minimized.

@matiasdelellis

This comment has been minimized.

@DrRSatzteil

This comment has been minimized.

@matiasdelellis
Copy link
Owner

Absolutely nothing strange y these logs.. 😕

Another test.. In the Network tab of the browser, look for a transfer like core/search?query=matias&inApps%5B%5D=files&page=1&size=30 while search..

@matiasdelellis
Copy link
Owner

Ohh.. Please try momentarily disabling the fulltextsearch application

@DrRSatzteil
Copy link
Author

Looks better now:
https://XXXXXXXXXXXXXXX/index.php/core/search?query=Schepers&inApps%5B%5D=files&page=1&size=30

And it found the correct results! It took quite a while though but there are about 18.000 pictures on my instance atm.

So apparently searching is not compatible with fulltextsearch!?

@matiasdelellis
Copy link
Owner

And it found the correct results!

Wow good 😄

It took quite a while though but there are about 18.000 pictures on my instance atm.

Maybe need need to see how to paginate the results. Since now it tries to return all the results ..

So apparently searching is not compatible with fulltextsearch!?

No.. Until now it is something I have never considered.. 😅 😞

Well .. I rename the Issue to reflect the real problem.

Thank you very much for for report and the feedback.. 😉

@matiasdelellis matiasdelellis changed the title Cannot find people when searchin in files app Searching persons on file is not compatible with fulltextsearch Apr 22, 2020
matiasdelellis added a commit that referenced this issue Apr 28, 2020
Use paginated search. Fix part of issue #263
@jacotec
Copy link

jacotec commented Jul 29, 2020

Hi

is there any update or workaround for this issue? After my server took 4 days to analyze our pictures with impressive results I've spent some hours looking why I can't find any pix by person's names ... before I found this thread.

Fulltextsearch is the #1 must for my servers ... how can I find pictures by name then?

@matiasdelellis
Copy link
Owner

is there any update or workaround for this issue?

Not yet .. Honestly, I would like to implement it, but I have no experience in it.
It's going to take time, unless someone else tries. Sorry.. 😞

After my server took 4 days to analyze our pictures with impressive results..

Great. Thanks. 😃

@jacotec
Copy link

jacotec commented Aug 5, 2020

Maybe it'll be an idea to have an option that the person's names could be maintained as a normal file tag, instead or in addition to the new "persons" field? With the names as a normal file tag I could at least filter for names ... right now I have no tool to find photos with persons as I don't have any ability to search for them.

@matiasdelellis
Copy link
Owner

Hi @jacotec
The tags were discussed here. #292 It is relatively easy to implement, but it degrades server performance fairly quickly. However the main reason for not implement it yet, is that I can't do it right. There is no way to give tags context. In any case, we discussed it there.

About this issue (Implement fulltextsearch), as I said, still dont did it because I have no experience with this application. I honestly never test it because beyond the original announcement, Nextcloud never gave it much importance, and now they are changing the search framework, but again I think compatible with fulltextsearch.

@matiasdelellis
Copy link
Owner

Hello everyone,
With the introduction of Unified Search I think we can close this ticket .. Thank you very much !! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants