Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error while deleting from other app. #471

Closed
storm1er opened this issue May 14, 2021 · 5 comments
Closed

Error while deleting from other app. #471

storm1er opened this issue May 14, 2021 · 5 comments

Comments

@storm1er
Copy link

Expected behaviour

All deletion should happen correctly

Actual behaviour

Deleting files with faces from the duplicate finder app gives this error:

Argument 1 passed to OCA\FaceRecognition\Db\PersonMapper::removeIfEmpty() must be of the type int, string given, called in /var/www/html/custom_apps/facerecognition/lib/Hooks/FileHooks.php on line 297

Steps to reproduce

  1. Install and use facerecognition app
  2. Install and use duplicatefinder app
  3. Remove a duplicate photo with face from duplicate finder app

Server configuration

  • Nextcloud version: 21
@matiasdelellis
Copy link
Owner

Hi @storm1er

It's strange.. 🤔
It may be that you're using PHP 8?

@storm1er
Copy link
Author

Nope, php 7.4.18

Just realized I have the same problem by deleting any photo with a face from the file explorer, so no third app concerned.

@matiasdelellis
Copy link
Owner

Hi @storm1er,
You're right. I was able to reproduce the error easily. 😞

I hope to give news soon.
Thanks

@matiasdelellis matiasdelellis mentioned this issue May 16, 2021
Merged
matiasdelellis added a commit that referenced this issue May 17, 2021
@matiasdelellis
Face recognition V0.8.2
5e921a2 
- Add links in thumbnails of rename persons dialogs. Issue #396
- Initial autocomplete feature for names. Issue #306

- Respect .noimage file, since it is also used in Photos. Issue #446
- Fix delete files due some change on ORM with NC21. Issue #471
- Some fixes on make clean.

- New Italian translation thanks to axl84, and update others. Thank you so much
  everyone.
@matiasdelellis matiasdelellis mentioned this issue May 17, 2021
Merged
@matiasdelellis
Copy link
Owner

Must be fixed on last release.. Please, test.. 😬

@storm1er
Copy link
Author

Fixed :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matiasdelellis @storm1er