Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide autocomplete of existing persons while manual tagging faces on images #639

Open
lippoliv opened this issue Mar 5, 2023 · 2 comments

Comments

@lippoliv
Copy link

lippoliv commented Mar 5, 2023

Hey, Thanks for reporting issues back to Nextcloud Face Recognition. Please, try to complete this report in detail so we can help you easier. 馃槃

Make sure you read all the documentation, and the FAQ, and that the issue has not been reported before. 馃槈

Expected behaviour

On images in the "faces" tab of the sidebar, I see who is tagged on the image. For faces who are recognized, but not named yet, I can add a name.

I should be able to select existing persons, beside creating new ones on the fly.

Actual behaviour

I cannot select existing persons, I can just create new ones.

Steps to reproduce

  1. Open an image with an recognized face, which is not connected to a person
  2. Type in the name of an existing person

Server configuration

  • Operating system: Docker nextcloud:25.0.4-apache

  • Pdlib version:

    ARG DLIB_BRANCH=v19.24
    ARG PDLIB_BRANCH=master
    
  • How is DLib installed: Make sure it is working correctly with this tool

  • How is PDlib installed: Make sure it is working correctly with this tool

  • PHP version: PHP 8.1.16

  • Web server: Apache

  • Database: Docker mariadb:10.5

  • Nextcloud version: 25.0.4

Client configuration

  • Browser: Tested in Brave and Edge

  • Operating system: Windows 10

Logs

Background task log with debug.

sudo -u apache php occ -vvv face:background_job
unrelated

Web server error log

Web server error log
none

Nextcloud log (data/nextcloud.log)

Nextcloud log
none

Browser log

Browser log
none
@matiasdelellis
Copy link
Owner

Hi @lippoliv
Unfortunately this is a regression forced by a change in nextcloud 25.. (The side panel retains focus, and we can't focus on the dialog we use to search for people.)

I would like to solve it soon. Thank you very much for reporting it.

@lippoliv
Copy link
Author

Memories has implemented something like that, maybe not 100% what I described. But basically listen to the input and show some suggestions: pulsejet/memories#177

Maybe instead of a text field, we can open a dialog, if the user clicks on the "unknown face". Then we could let him select a existing face or create a new one?

In that dialog, we could probably (haven't reviewed source code yet) show most similar faces? That would be a quiet nice feature I gues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants