App is not compliant

[matiasdelellis]

App is not compliant

Just add this report to remember it.

Travis CI checks these reports but deliberately ignores them.

https://github.com/matiasdelellis/facerecognition/blob/master/.travis.yml#L32

Test

[matias@nube nextcloud]$ sudo -u apache php occ app:check-code  facerecognition
[sudo] password for matias: 
App is not compliant

Details:

OC_Util - Static method of private class must not be called

Analysing /var/www/html/nextcloud/apps/facerecognition/lib/BackgroundJob/Tasks/AddMissingImagesTask.php
 2 errors
    line  123: OC_Util - Static method of private class must not be called
    line  124: OC_Util - Static method of private class must not be called
Analysing /var/www/html/nextcloud/apps/facerecognition/lib/BackgroundJob/Tasks/StaleImagesRemovalTask.php
 2 errors
    line  137: OC_Util - Static method of private class must not be called
    line  138: OC_Util - Static method of private class must not be called
Analysing /var/www/html/nextcloud/apps/facerecognition/appinfo/app.php
 1 errors
    line   31: OC_Util - Static method of private class must not be called

Private API is used, therefore it is valid, however there is no replacement with public api. So, ignore this.

Fixed

Fixed on PR #196

Database schema error: Name of table dbprefixface_recognition... is too long:

Database schema error: Name of table *dbprefix*face_recognition_face_models is too long (28), max. 27 characters (21 characters for tables with autoincrement) + *dbprefix* allowed
Database schema error: Name of table *dbprefix*face_recognition_face_models is too long (28), max. 27 characters (21 characters for tables with autoincrement) + *dbprefix* allowed
Database schema error: Name of table *dbprefix*face_recognition_persons is too long (24), max. 27 characters (21 characters for tables with autoincrement) + *dbprefix* allowed
Database schema error: Name of table *dbprefix*face_recognition_images is too long (23), max. 27 characters (21 characters for tables with autoincrement) + *dbprefix* allowed
Database schema error: Name of table *dbprefix*face_recognition_faces is too long (22), max. 27 characters (21 characters for tables with autoincrement) + *dbprefix* allowed

Although we agree that long names are not recommended, we believe that it is not a problem.

OC_DB - Static method of private class must not be called

Analysing /var/www/html/nextcloud/apps/facerecognition/appinfo/update.php
 1 errors
    line   14: OC_DB - Static method of private class must not be called
Deprecated file found: /var/www/html/nextcloud/apps/facerecognition/appinfo/update.php - please use repair steps

It was a quick table migration that will be unnecessary after publishing the application, and will be directly deleted.

Fixed on PR #172

Invalid appinfo.xml file found: Element 'types': This element is not expected

Invalid appinfo.xml file found: Element 'types': This element is not expected. Expected is one of ( background-jobs, repair-steps, two-factor-providers, commands, settings, activity, dashboard, fulltextsearch, navigations, contactsmenu ).

Although it is not documented, it is necessary. So, ignore this.

• The hooks are not working #73
• app:check-code Element 'types' is not expected nextcloud/server#12942

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[stalker314314]

ahould we changes tables to something shorter, I don't know, *dbprefix*facerec_persons or *dbprefix*face_rec_persons?

[matiasdelellis]

If you want to do it, welcome... 😉
However forgot to comment that almost no official application meets its standards.. 😅

See: https://github.com/search?q=org%3Anextcloud+App+is+not+compliant&type=Issues

I guess it would be better to continue with other priorities..

[PixsaOJ]

Here is my output of that command

bash-4.4$ php occ app:check-code  facerecognition
Analysing /var/www/html/nextcloud/apps/facerecognition/lib/Model/ExternalModel/ExternalModel.php
 1 errors
    line  178: == - is discouraged
Analysing /var/www/html/nextcloud/apps/facerecognition/lib/Controller/FaceController.php
 2 errors
    line  172: OC_App - Static method of private class must not be called
    line  191: OC_App - Static method of private class must not be called
Analysing /var/www/html/nextcloud/apps/facerecognition/lib/Service/FileService.php
 2 errors
    line   75: OC_Util - Static method of private class must not be called
    line   76: OC_Util - Static method of private class must not be called
App is not compliant

EDIT:
Server is running Centos 8 and PHP 7.4.15