Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

[馃敹 Change request ]: Activations should be case insensitive #45

Merged

Conversation

and1can
Copy link
Contributor

@and1can and1can commented Dec 6, 2021

#44 Activations should be case insensitive

  • Making the activations all lowercase to be case insensitive.
  • activation.js, name of activation made lowercase before inserting into activations dictionary.
  • addHiddenLayer.js, act - name of activation made lowercase before checking the activation name from dictionary.
  • outputActivation.js, act - name of activation made lowercase before checking the activation name
  • setFunc.js, act - activation name made lowercase
  • stringTofunc.js, act - activation name made lowercase
  • actfuncs.js, made each of the activation names to be all lowercase from definition of activations
  • test/unit/classes/dann.js - update tests to have all activations functions be lowercase
  • test/unit/core/functions/actfuncs.js - update tests to have all activations functions be lowercase
  • test/unit/core/functions/add.js - include test that users can add a new layer that will have activations function name be changed to lowercase and a minor typo from a test.

@matiasvlevi
Copy link
Owner

Thank you and1can!
I am merging your PR.

@matiasvlevi matiasvlevi merged commit 859b0a9 into matiasvlevi:master Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants