This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
[馃敹 Change request ]: Activations should be case insensitive #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44 Activations should be case insensitive
activation.js
,name
of activation made lowercase before inserting intoactivations
dictionary.addHiddenLayer.js
,act
- name of activation made lowercase before checking the activation name from dictionary.outputActivation.js
,act
- name of activation made lowercase before checking the activation namesetFunc.js
,act
- activation name made lowercasestringTofunc.js
,act
- activation name made lowercaseactfuncs.js
, made each of the activation names to be all lowercase from definition ofactivations
test/unit/classes/dann.js
- update tests to have all activations functions be lowercasetest/unit/core/functions/actfuncs.js
- update tests to have all activations functions be lowercasetest/unit/core/functions/add.js
- include test that users can add a new layer that will have activations function name be changed to lowercase and a minor typo from a test.