Django ninja support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maticardenas
force-pushed
the
14-add-support-for-django-ninja-test-client
branch
15 times, most recently
from
70a8e32
to
7ee42ce
Compare
maticardenas
force-pushed
the
14-add-support-for-django-ninja-test-client
branch
6 times, most recently
from
6c51ecf
to
619dd6b
Compare
maticardenas
force-pushed
the
14-add-support-for-django-ninja-test-client
branch
from
619dd6b
to
7935e41
Compare
maticardenas
force-pushed
the
14-add-support-for-django-ninja-test-client
branch
from
7935e41
to
6587d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Even though Django Ninja is compatible with Django itself, the way DRF and Django Ninja responses work is slightly different.
For testing (which concerns to this package), DRF endpoints responses are of type
rest_framework.response.Responsewheres Django Ninja ones are of typedjango.http.response.HttpResponseThis brings the need of adapting the package in order to properly handle responses for contract validation.
It will also bring other necessary later enhancements specially as we extend the package, but the goal for this PR is just give the minimum support to make it work with Django Ninja APIs as it is.
Changes
django.http.response.HttpResponsetype responses.django-ninjaas extra dependency.django-ninjaAPI as part of the test project and corresponding tests3.8