Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Optimize testcases #8

Closed
jdkanani opened this issue Jun 18, 2018 · 2 comments
Closed

Optimize testcases #8

jdkanani opened this issue Jun 18, 2018 · 2 comments

Comments

@jdkanani
Copy link
Contributor

Currently, test cases take too much time as it deploys contracts on each test-case. Make changes such a way that it can be deployed once, and can used as many as times you want.
@jdkanani
Copy link
Contributor Author

jdkanani commented Aug 7, 2018

Pull request #10 improves ci performance by using Parity node.

@jdkanani
Copy link
Contributor Author

Implemented in #16

0xAshish added a commit that referenced this issue May 29, 2020
@0xAshish
inherit from IGovernance #8 issue
dc42d12
atvanguard added a commit that referenced this issue May 30, 2020
@0xAshish @atvanguard
Audit fixes (#278)
8769925 
* fix reentrancy attack on claim fee #5 issue

* fix _transfer override for validator share #1 issue

* inherit from IGovernance #8 issue

* add events for update functions #7 issue

* add slippage rate validation in buy/sell voucher

* fix test contract

* fix tests

* add tests for buy/sell slippage and disabled trasnfer

* fix import

* dev: change buy/sell voucher signature

* test: add exact amount tests for sell/buy voucher

Co-authored-by: atvanguard <93arpit@gmail.com>
@snyk-bot snyk-bot mentioned this issue Sep 26, 2021
Open
This was referenced Dec 9, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue Apr 4, 2022
Open
@cleancoindev cleancoindev mentioned this issue May 12, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdkanani