FeedHeaderPoS already writes header number (ledgerwatch#4626)

* FeedHeaderPoS already calls WriteHeaderNumber * Moreover, WriteHeader already writes to HeaderNumber
maticnetwork · Jul 4, 2022 · 00ee68e · 00ee68e
1 parent 2a0fda3
commit 00ee68e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/eth/stagedsync/stage_headers.go b/eth/stagedsync/stage_headers.go
@@ -584,10 +584,6 @@ func verifyAndSaveNewPoSHeader(
 		}, false, nil
 	}
 
-	if err := rawdb.WriteHeaderNumber(tx, headerHash, headerNumber); err != nil {
-		return nil, false, err
-	}
-
 	if err := headerInserter.FeedHeaderPoS(tx, header, headerHash); err != nil {
 		return nil, false, err
 	}

diff --git a/turbo/stages/headerdownload/header_algos.go b/turbo/stages/headerdownload/header_algos.go
@@ -898,9 +898,6 @@ func (hi *HeaderInserter) FeedHeaderPoS(db kv.GetPut, header *types.Header, hash
 		return fmt.Errorf("[%s] failed to WriteTd: %w", hi.logPrefix, err)
 	}
 	rawdb.WriteHeader(db, header)
-	if err = rawdb.WriteHeaderNumber(db, hash, blockHeight); err != nil {
-		return err
-	}
 
 	hi.highest = blockHeight
 	hi.highestHash = hash