Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

[DVT-85] add goreleaser to erigon github actions #3

Merged
merged 16 commits into from
Jul 6, 2022

Conversation

rebelArtists
Copy link

@rebelArtists rebelArtists commented Jul 5, 2022

to streamline the release process of new maticnetwork/erigon code changes, we've added a github actions automated workflow with goReleaser to support a wide variety of operating systems and linux distributions

linear ticket: https://linear.app/matic/issue/DVT-85/erigon-ci-flow

leveraging similar goReleaser structure already in place for bor, as seen here

the release process is triggered upon pushing a semantic-versioned tag, for example:
git tag v0.0.3 091ae61
git push origin dan/goreleaser_erigon tag v0.0.3

successful goReleaser github action run logs here: https://github.com/maticnetwork/erigon/runs/7202381340?check_suite_focus=true

further confirmations:

  • initial dockerhub release with this system successful, see: https://hub.docker.com/r/0xpolygon/erigon/tags
  • pulling down the dockerhub arm64 image locally, erigon is able to run successful, with following command:
    docker run 0xpolygon/erigon:0.0.2-alpha-arm64 --chain=mainnet \ --datadir /var/lib/erigon/data

image

- binaries also properly uploaded to github releases, see: https://github.com/maticnetwork/erigon/releases

@rebelArtists rebelArtists changed the title [wip] add goreleaser to erigon github actions [DVT-85] add goreleaser to erigon github actions Jul 5, 2022
@linear
Copy link

linear bot commented Jul 5, 2022

DVT-85 Erigon CI Flow

Create some workflow so that when a new version of erigon is tagged, a new version will be built and pushed to dockerhub:

@rebelArtists rebelArtists marked this pull request as ready for review July 5, 2022 20:08
[Service]
Restart=on-failure
RestartSec=5s
ExecStart=/usr/local/bin/erigon \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have to specify the bindir for nfpm or does it default to this location

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@praetoriansentry praetoriansentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do some testing of the released artifacts. I think it's going to take some work to support operating systems that aren't using systemd or situations where people want to customize which network they're connecting to. I think for now, it's possible just to remove the service file and ship the binary.

@rebelArtists
Copy link
Author

We need to do some testing of the released artifacts. I think it's going to take some work to support operating systems that aren't using systemd or situations where people want to customize which network they're connecting to. I think for now, it's possible just to remove the service file and ship the binary.

agreed, seems an opportunity for us to setup up an automatic testing system for the releases on various linux distributions.. for now, i've removed the nfpms section / service file and i can file a ticket for this be a follow-on task

@rebelArtists rebelArtists merged commit 5247fe9 into devel Jul 6, 2022
Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM but no deb/rpm packages?

@vcastellm vcastellm deleted the dan/goreleaser_erigon branch July 11, 2022 09:42
0xKrishna pushed a commit that referenced this pull request Jul 14, 2022
* experiment #1

* experiment #2

* experiment #3

* experiment 4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants