Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

mardizzone/pos-944: snyk and govuln integration #8

Merged
merged 10 commits into from
Nov 16, 2022
Merged

Conversation

marcello33
Copy link

@marcello33 marcello33 commented Nov 10, 2022

Description

This PR integrates snyk security CI into bor GH pipeline.
It executes snyk vulnerabilities check and snyk static code analysis and publish the results into the relative action.
Licenses check has been removed from snyk UI as ours is a open source organization.
Also, it solves some high security issues (not related to licenses).

Furthermore it integrates govuln check as additional step in the tests (if the OS is ubuntu), to check if the code has any golang related vulnerabilities.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Used snyk CLI for tests, and embedded security-ci on PR.

@marcello33 marcello33 marked this pull request as ready for review November 11, 2022 12:39
cmd/evm/runner.go Outdated Show resolved Hide resolved
@marcello33 marcello33 requested a review from a team November 14, 2022 10:18
@marcello33 marcello33 changed the title mardizzone/pos-944: Snyk integration mardizzone/pos-944: snyk and govuln integration Nov 15, 2022
@0xKrishna 0xKrishna merged commit 905f081 into devel Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants