Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy multiple devnets #105

Merged
merged 18 commits into from
Nov 28, 2022
Merged

Deploy multiple devnets #105

merged 18 commits into from
Nov 28, 2022

Conversation

Raneet10
Copy link
Member

Description

This PR intends to introduce the possibility of deploying and working with multiple devnets via express-cli. The commands are modified so as to point to a specific devnet while executing them.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

Copy link
Contributor

@marcello33 marcello33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the whole concept must be re-worked according to specs.

@Raneet10 Raneet10 marked this pull request as ready for review November 24, 2022 04:35
Copy link
Contributor

@marcello33 marcello33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@marcello33 marcello33 merged commit 6e53862 into master Nov 28, 2022
@marcello33 marcello33 deleted the raneet10/pos-879 branch November 30, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants