Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for EIP-1559 txs #128

Merged
merged 7 commits into from
Dec 5, 2022
Merged

Add test for EIP-1559 txs #128

merged 7 commits into from
Dec 5, 2022

Conversation

Raneet10
Copy link
Member

@Raneet10 Raneet10 commented Dec 5, 2022

Description

This PR adds a command to run EIP-1559 tx as a test.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@linear
Copy link

linear bot commented Dec 5, 2022

POS-538 Run EIP-1559 test script in CI

https://github.com/maticnetwork/eip1559-test-scripts contains some useful functions that test old tx and new tx after EIP-1559. However, it is not directly usable/deployable in CI due to some problems. For example, we need to manually modify .env file to change private keys, and provide mnemonic words, which is not available in devnet.

Also, testAll.js will not exit when either tests succeed or fail. We should make the script exit with non-zero code when some test fail.

src/express/common/config-utils.js Outdated Show resolved Hide resolved
.env.example Show resolved Hide resolved
.env.example Show resolved Hide resolved
README.md Show resolved Hide resolved
@marcello33 marcello33 marked this pull request as ready for review December 5, 2022 09:38
@marcello33 marcello33 merged commit be29889 into master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants