Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: chg: POS-1215 move sonarqube to own ci #153

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

marcello33
Copy link
Contributor

Description

This PR moves sonarqube into its own security ci.
This is use to the fact that our current sonarqube version can only run on 1 branch, the default one (master in this case).
Since we want to keep majority of the checks on the PR level, we’ll move sonarqube into a separate yaml until license will be extended to run on every PR.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

@marcello33 marcello33 changed the title dev: chg: POS-215 move sonarqube to own ci dev: chg: POS-1215 move sonarqube to own ci Feb 8, 2023
@maticnetwork maticnetwork deleted a comment from linear bot Feb 8, 2023
@marcello33 marcello33 requested a review from a team February 8, 2023 13:51
@marcello33 marcello33 merged commit 1c6fd20 into master Feb 9, 2023
@pratikspatil024 pratikspatil024 deleted the mardizzone/POS-1215 branch February 9, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants