Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mardizzone/small-fixes #87

Merged
merged 2 commits into from
Oct 27, 2022
Merged

mardizzone/small-fixes #87

merged 2 commits into from
Oct 27, 2022

Conversation

marcello33
Copy link
Contributor

Description

Hotfix a broken path for genesis file in heimdall.
Also, gitignore devnet configs and provide instructions on how to avoid pushing/deleting them.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • [] I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@marcello33 marcello33 merged commit b86f6c4 into master Oct 27, 2022
@marcello33 marcello33 deleted the mardizzone/small-fixes branch October 27, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raneet10 Raneet10 Raneet10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcello33 @Raneet10