Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mintable ERC20 & ERC1155 Predicate [ READY FOR REVIEW ] #62

Merged
merged 31 commits into from
Feb 12, 2021
Merged

Mintable ERC20 & ERC1155 Predicate [ READY FOR REVIEW ] #62

merged 31 commits into from
Feb 12, 2021

Conversation

itzmeanjan
Copy link
Contributor

changes

  • Mintable ERC20 & ERC1155 Predicates
  • Along with respective default child token contracts
  • Also respective dummy root token contracts

@itzmeanjan
new: mintable ERC20 interface
80daa46
@itzmeanjan
new: Mintable ERC20 predicate
5051935
@itzmeanjan
new: upgradable proxy contract for mintable ERC20
611464c
@itzmeanjan
new: dummy mintable erc20 contract, can be deployed on root chain
25f3249
@itzmeanjan
new: default child token for mintable erc20
56d81e4
@itzmeanjan
new: mintable erc1155 predicate proxy contract
1d8d34d
@itzmeanjan
new: interface for root mintable erc1155 contract
b28c997
@itzmeanjan
chg: removed usage of safemath library by making operations safe
2e81c64
@itzmeanjan
new: mintable erc1155 predicate
9e4de03
@itzmeanjan
new: dummy mintable erc1155
8fe3bed
@itzmeanjan
new: default child mintable erc1155 token
8f1f3a7
@itzmeanjan
fix: function parameter storage location fixed
db699a7
@itzmeanjan
new: flatten contract generator
fda9015
@itzmeanjan
new: artifacts generator for new contracts
4aab3b0
@itzmeanjan
fix: mintable token's interface fixed
1233ba7
@itzmeanjan
chg: fixed undeclared variable name
474d728
@itzmeanjan
new: generated flattened contracts
309c2da
@itzmeanjan
new: migration scripts for root & child chain contracts
51545e5
@itzmeanjan
new: migration script for initializing root & child chain contracts
ec99017
@itzmeanjan
fix: function signature issue resolved
eccba08
@itzmeanjan
udt: updated flattened contracts generated
7c9d6ab
@itzmeanjan
new: artifacts of new root & child contracts generated
a6faea8
@itzmeanjan itzmeanjan marked this pull request as ready for review December 21, 2020 16:31
@itzmeanjan itzmeanjan changed the title Mintable ERCE20 & ERC1155 Predicate [ DON'T MERGE ] Mintable ERCE20 & ERC1155 Predicate [ READY FOR REVIEW ] Dec 21, 2020
@itzmeanjan itzmeanjan changed the title Mintable ERCE20 & ERC1155 Predicate [ READY FOR REVIEW ] Mintable ERC20 & ERC1155 Predicate [ READY FOR REVIEW ] Dec 21, 2020
imyourm8
imyourm8 suggested changes Dec 29, 2020
View reviewed changes
Copy link

@imyourm8 imyourm8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, I only miss a set of tests for the new predicates.

@itzmeanjan
Copy link
Contributor Author

Everything looks good, I only miss a set of tests for the new predicates.

Ok, I'll write some.

@itzmeanjan
Copy link
Contributor Author

Wrote some test cases, if you could review @jdkanani , @imyourm8

coinsandsteeldev
coinsandsteeldev approved these changes Jan 30, 2021
View reviewed changes
Copy link

@coinsandsteeldev coinsandsteeldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@itzmeanjan
Copy link
Contributor Author

Deployment done. Details : 0xPolygon/static#42

@itzmeanjan itzmeanjan merged commit 38c30b0 into master Feb 12, 2021
@itzmeanjan itzmeanjan deleted the mintable-erc20-and-erc1155-predicate branch February 12, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imyourm8 imyourm8 imyourm8 approved these changes

@jdkanani jdkanani jdkanani approved these changes

@coinsandsteeldev coinsandsteeldev coinsandsteeldev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@itzmeanjan @imyourm8 @jdkanani @coinsandsteeldev