Fix Error Handling Behaviour #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a response containing errors and no data would fail if the selection expected a non-null field. I wrongly assumed that if the error may be raised, it's going to only be raised with nullable fields. In reality, that assumption is wrong and the client should be able to handle a faulty response regardless of the GraphQL schema.
This PR is a breaking change that changes the error type of the client interface.
This PR is related to #99 which served as a basis for this PR. Even though I created a new PR, VladNaimark lay the ground work and should deserve the credit for the work.
You can read more about the pattern here in urql documentation which served as inspiration for the new functionality.