Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iOS Version Requirement to iOS 16, Improve Documentation #137

Merged
merged 6 commits into from
Jun 19, 2023

Conversation

robsontenorio
Copy link
Contributor

@robsontenorio robsontenorio commented Jun 17, 2023

Fix #136

  • Set version to iOS16
  • Small doc update

@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swift-graphql ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 8:19am

A little help for beginners.
@robsontenorio robsontenorio changed the title Bump iOS Version Bump iOS Version + small doc improvement Jun 17, 2023
@maticzav
Copy link
Owner

I see that you tested other versions as well! Does it not work with v14? I am hesitant to make such a huge version jump unless it's necessary.

@maticzav maticzav self-assigned this Jun 18, 2023
@robsontenorio
Copy link
Contributor Author

@maticzav as you can see on #136 screenshots v15 is necessary for some functions.

@Amzd
Copy link
Contributor

Amzd commented Jun 19, 2023

Specifically FilePath.appending https://developer.apple.com/documentation/system/filepath/appending(_:)-1dtn3

@maticzav
Copy link
Owner

I see, but why are we enforcing .ios(.v16) then?

@maticzav maticzav merged commit 0388098 into maticzav:main Jun 19, 2023
3 checks passed
@maticzav
Copy link
Owner

Hey, I tried running tests on iOS 15 (in the CI, sorry) and went ahead and merged it to unblock you. Let me know if I missed something and we should have instead used iOS 16 as a base.

Thank you for opening a PR! ❤️

@robsontenorio
Copy link
Contributor Author

@maticzav yes, v15 is enough for a while. Thanks!

@maticzav maticzav changed the title Bump iOS Version + small doc improvement Bump iOS Version Requirement to iOS 16, Improve Documentation Jul 6, 2023
@maticzav
Copy link
Owner

maticzav commented Jul 6, 2023

To give a bit more context to why I decided that we can safely bump the version; considering iOS installation charts, it seems like almost no iPhone relies on iOS 14 anymore statista.com/statistics/565270/apple-devices-ios-version-share-worldwide.

SwiftGraphQL relies on certain APIs that rely on iOS 15, though if I recall correctly, they may be substituted for alternatives that have better legacy support. In case you need to support older versions of iOS, please open an issue thoroughly explaining your case and the constraints that you have to work around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing 5.0.1
3 participants