Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description for ID field #11

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Update description for ID field #11

merged 3 commits into from
Feb 25, 2024

Conversation

mdanish-kh
Copy link
Contributor

@matifali
Copy link
Owner

Thank you @mdanish-kh. Choosing id was a personal choice to not confuse it with display name or version name. As version names are set with --name flag in CLI.

I plan to revisit this sometimes in future and align all fields with CLI and API equivalents.

@matifali matifali merged commit 8f1095a into matifali:main Feb 25, 2024
1 check passed
@mdanish-kh mdanish-kh deleted the description branch February 25, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

id description can be made clearer
2 participants
@mdanish-kh @matifali