Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process shaders during build #202

Merged
merged 1 commit into from Apr 5, 2024
Merged

Process shaders during build #202

merged 1 commit into from Apr 5, 2024

Conversation

xiota
Copy link
Contributor

@xiota xiota commented Apr 5, 2024

Process shaders during build, rather than after install. Fixes #201.

matinlotfali
matinlotfali approved these changes Apr 5, 2024
View reviewed changes
Copy link
Owner

@matinlotfali matinlotfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it is working well!

@matinlotfali matinlotfali merged commit c3fd30c into matinlotfali:master Apr 5, 2024
5 checks passed
@xiota xiota deleted the pr_shaders branch April 5, 2024 07:32
@xiota
Copy link
Contributor Author

xiota commented Apr 9, 2024 •
edited

I've been reading about cmake, and it might be possible to put the commands directly in add_custom_target (instead of separate add_custom_command). Probably not worth changing now because it is working. But something to consider if the file has to be revised for another reason.

@matinlotfali
Copy link
Owner

Thanks for sharing @xiota

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matinlotfali matinlotfali matinlotfali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repeatedly segfaults on load
2 participants
@xiota @matinlotfali