Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Summary table under summary section #33

Merged
merged 96 commits into from
Jul 2, 2024
Merged

Add Summary table under summary section #33

merged 96 commits into from
Jul 2, 2024

Conversation

nbhoski
Copy link
Contributor

@nbhoski nbhoski commented May 24, 2024

This PR is a continuation of last feature of supporting workflow commands in GitHub logs. This PR introduces a Summary table under GitHubs Summary page. as shown below. This feture uses BuildSummaryPlugin.m file for generating buildSummary_<RUN_ID> under RUNNER_TEMP folder. Which is further used to generate the summary table as shown below. Unit test are included under buildSummary.unit.test.ts

All Passed

image

Skipped

image

Failed

image

Copy link
Collaborator

@davidbuzinski davidbuzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. +1 to the double logging with try/catch that Sam mentioned, and the error handling concerns that Mark raised as well.

src/buildSummary.ts Outdated Show resolved Hide resolved
src/buildSummary.ts Outdated Show resolved Hide resolved
src/buildSummary.ts Outdated Show resolved Hide resolved
src/buildSummary.ts Outdated Show resolved Hide resolved
src/buildSummary.ts Outdated Show resolved Hide resolved
src/buildSummary.ts Outdated Show resolved Hide resolved
src/buildSummary.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/buildSummary.ts Outdated Show resolved Hide resolved
src/buildSummary.ts Outdated Show resolved Hide resolved
@nbhoski nbhoski requested a review from sameagen-MW July 1, 2024 06:09
src/index.ts Outdated Show resolved Hide resolved
@nbhoski nbhoski requested a review from mcafaro July 1, 2024 15:33
src/buildSummary.ts Outdated Show resolved Hide resolved
src/buildSummary.ts Outdated Show resolved Hide resolved
@nbhoski nbhoski requested a review from mcafaro July 1, 2024 17:39
src/buildSummary.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@nbhoski nbhoski merged commit b8ca34d into main Jul 2, 2024
1 check passed
@nbhoski nbhoski deleted the summary_table branch July 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants