Updating predictMaskedToken.m to match new tokenizer. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwdGitHub
reviewed
Apr 19, 2023
test/tpredictMaskedToken.m
Outdated
Comment on lines
8
to
10
| AllModels = {"base","multilingual-cased","medium",... | ||
| "small","mini","tiny","japanese-base",... | ||
| "japanese-base-wwm"} |
There was a problem hiding this comment.
Given the tokenizers are the same for most the BERTs I think it's fine to just test "tiny" and one of the Japanese BERTs.
|
Feel free to merge after checking the one comment I made - I thought there was an "approve" button for GitHub PRs. If you want to be pedantic you could create a bug Issue and close it with the PR. My thought there is maybe some users would like to see what bugs existed, and what commits/merges fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating predictMaskedToken.m to match new tokenizer. Also included test file to make sure we flag this in future submissions.
The README was also changed to include pointers to where find the data sets used in the GitHub examples.