Restore compatibility with Octave 6.x or newer #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of `legend` was completely overhauled for Octave 6.x. Implementation details have changed. The new code still uses undocumented implementation details that might change in the future. But I don't know of a documented way to get that information. See also this bug reported on Octave's bug tracker: https://savannah.gnu.org/bugs/?61352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
legendwas completely overhauled for Octave 6.x. Implementation details have changed.That causes
matlab2tikzto fail with these versions of Octave.The proposed code still uses undocumented implementation details that might change in the future. But I don't know of a documented way to get that information.
See also this bug reported on Octave's bug tracker:
https://savannah.gnu.org/bugs/?61352
I haven't tested these changes myself. But @AndreasStahel reported the updated code works for him.